Fix deprecation toc arguments in component lifecycle hooks #691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjornharrtell
force-pushed
the
fix-deprecation-toc_arguments-in-component-lifecycle-hooks
branch
from
74f64c0
to
baa400a
Compare
bjornharrtell
force-pushed
the
fix-deprecation-toc_arguments-in-component-lifecycle-hooks
branch
from
baa400a
to
f2c15ff
Compare
|
Rebased. |
bjornharrtell
force-pushed
the
fix-deprecation-toc_arguments-in-component-lifecycle-hooks
branch
from
f2c15ff
to
0c36d37
Compare
|
Rebased once more without dependency on #690. |
|
We might consider using this as well |
|
This is also fixed with #726 which I hope will get merged soon. Closing this. |
bjornharrtell
deleted the
fix-deprecation-toc_arguments-in-component-lifecycle-hooks
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://emberjs.com/deprecations/v2.x/#toc_arguments-in-component-lifecycle-hooks.